feat(Flyout): Added optional background prop #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b8a43e9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
…into hr-disc-1007-flyout-bg
This reverts commit 0564b1b.
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
saghdaey
approved these changes
Dec 15, 2022
jakemhiller
added a commit
that referenced
this pull request
Dec 16, 2022
* origin/main: chore(release): publish chore: update local node version to v16 [WEB-2205] chore(release): publish refactor(ScoreSummary): make ScoreSummary responsive chore(release): publish feat(Flyout): Added optional background prop (#2627) chore(release): publish fix: update width of page alert to match page contents
jakemhiller
added a commit
that referenced
this pull request
Jan 6, 2023
* main: (30 commits) chore(release): publish feat(FormGroupLabel, GridForm): assorted embedded user-form features chore(release): publish fix(Flyout): move background color to fix overflow chore(release): publish chore: update local node version to v16 [WEB-2205] chore(release): publish refactor(ScoreSummary): make ScoreSummary responsive chore(release): publish feat(Flyout): Added optional background prop (#2627) chore(release): publish fix: update width of page alert to match page contents chore(release): publish chore(AppHeader)!: Remove bookmarks and favorites chore(release): publish fix(RatingsBar): Conditional box shadow (hide if 0%) chore(release): publish refactor(ScoreSummary): make trackSlug and tracking optional in ScoreSummary chore(release): publish feat(Footer): rename Pro Membership link ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow gamut Flyout component to have changeable background color.
PR Checklist
Testing Instructions
bgpropPR Links and Envs