This repository has been archived by the owner on Oct 26, 2020. It is now read-only.
Altom week-8 #1006
Open
Altom week-8 #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| createH2.textContent = greet; | ||
| getHtmlDoc.appendChild(createH2); | ||
| } |
There was a problem hiding this comment.
You got wrong here, the random greeting should be displayed in the box not to display it in a h2 and you don't have .catch if there is an error. It needs to be fixed.
| content.appendChild(createUl); | ||
| } | ||
|
|
||
| getBtn.addEventListener("click", getData); |
There was a problem hiding this comment.
Good job Altom, the only thing which is missing error handling when the data is fetched. Try to reorder you these function it looks messy.
| let createImg = document.createElement("img"); | ||
| createImg.src = image; | ||
| content.appendChild(createImg); | ||
| } |
There was a problem hiding this comment.
Good Work, The missing part is the error handling code on the fetched data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name:
Your City:
Your Slack Name:
Homework Details
Module:
Week: