Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clojure hooks #827

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Fix Clojure hooks #827

merged 3 commits into from
Aug 28, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Aug 23, 2023

No description provided.

@fmeum fmeum requested a review from zgtm August 23, 2023 14:25
@fmeum
Copy link
Contributor Author

fmeum commented Aug 23, 2023

@zgtm Could you check whether the other hooks are affected by this problem as well?

@fmeum fmeum force-pushed the clean-up-clojure-tests branch 2 times, most recently from ac4fa8f to 87ac314 Compare August 24, 2023 10:02
@fmeum
Copy link
Contributor Author

fmeum commented Aug 24, 2023

@zgtm I reduced the variance in test runtime by adding -use_value_profile=1. CI is green now.

@fmeum fmeum force-pushed the clean-up-clojure-tests branch from 87ac314 to 960fb7e Compare August 24, 2023 12:52
@fmeum fmeum changed the title Clean up clojure tests Fix Clojure hooks Aug 28, 2023
@zgtm
Copy link
Member

zgtm commented Aug 28, 2023

@zgtm Could you check whether the other hooks are affected by this problem as well?

This should also affect the hook numberUnsignedDivide in src/main/java/com/code_intelligence/jazzer/runtime/TraceDivHooks.java. Though I have not been able to tweak the test to show different behaviour, here …

zgtm
zgtm approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@zgtm zgtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this! I've added another commit, feel free to squash into your first commit!

fmeum and others added 3 commits August 28, 2023 16:20
@fmeum fmeum force-pushed the clean-up-clojure-tests branch from f6f52a7 to 25e86f5 Compare August 28, 2023 14:21
@fmeum
Copy link
Contributor Author

fmeum commented Aug 28, 2023

Thanks for finding and fixing this! I've added another commit, feel free to squash into your first commit!

Made the exact same change at a similar time (only with an additional comment) :-)

@fmeum fmeum enabled auto-merge (rebase) August 28, 2023 14:21
@fmeum fmeum merged commit 2212173 into main Aug 28, 2023
@fmeum fmeum deleted the clean-up-clojure-tests branch August 28, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zgtm zgtm zgtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @zgtm