Check social_media_url changed from default value #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +16,7 @@ | |||
| * The specification now strips the indentation of the `prefix_header` and | |||
| `prepare_command` to aide their declaration as a here document (similarly to | |||
| what it already does with the description). | |||
| [Fabio Pelosin][irrationalfab] | |||
| [Fabio Pelosin](https://github.com/irrationalfab) | |||
There was a problem hiding this comment.
This was fine because the link is declared at bottom of the file 😄. However don't worry it works this way as well.
There was a problem hiding this comment.
Oops. Didn't notice that. Should I change back?
Just learned a new feature of Markdown. Thanks man! 😉
There was a problem hiding this comment.
No need to change it back, it still works 🏄
|
This looks good to me, I'm just waiting for Travis which is being a bit slow today https://travis-ci.org/CocoaPods/Core/pull_requests. Thanks for the contribution! |
|
You're welcome. However, I forced pushed the commit and removed that change. |
|
Nice! Merging! |
fabiopelosin
added a commit
that referenced
this pull request
Apr 1, 2014
Check social_media_url changed from default value
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
Check social_media_url changed from default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial work by just duplicating the logic and spec from homepage check.
This closes #67.
