Better linting for Github URIs.

[neonichu]

Actually check URI.host and URI.scheme instead of checking against hardcoded URLs.

Does not longer warn for Github repositories with OAuth authentication, which was reported in CocoaPods/CocoaPods#1928

[joshkalpin]

I like this a lot. Can you make sure to update the changelog on the main repository?

[fabiopelosin]

👍

[kylef]

These changes seem to drop the check for gist.github.com, is this intentional?

[neonichu]

oops, no that wasn't intended, just slipped by. I will create a corresponding spec and fix.

[Superbil]

Oh no, use URI.parse will has side effect. Because we use local path as git repo.

example for path:

/Volumes/myrepo/source code/

URI.parse will throw out InvalidURIError

irb(main):012:0> URI.parse('/Volumes/myrepo/source code/')
URI::InvalidURIError: bad URI(is not URI?): /Volumes/myrepo/source code/
    from /usr/local/Cellar/ruby/2.1.1/lib/ruby/2.1.0/uri/common.rb:176:in `split'
    from /usr/local/Cellar/ruby/2.1.1/lib/ruby/2.1.0/uri/common.rb:211:in `parse'
    from /usr/local/Cellar/ruby/2.1.1/lib/ruby/2.1.0/uri/common.rb:747:in `parse'
    from (irb):12
    from /usr/local/opt/ruby/bin/irb:11:in `<main>'

[neonichu]

Oh, will a correct URI work in this case, file:///Volumes/myrepo/source%20code/ for your example?

[Superbil]

There is no limit for git repo is working on local path or url path. No mater what that path, it is work just fine.

Because this problem, I must change git source path on every pod specs.
Is there had another way to check github or gist repo ?!

[kylef]

@Superbil this is now tracked in #82 and should hopefully be fixed soon, it's only an issue with the linter so installation should work fine.