Ensure that specs can safely round-trip through JSON #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we target |
|
The alternative that we'd discussed was we could create a new hash and copy the keys/values over into the new hash. I think that would make the intent more clear, and be more future proof. We could do that change later though. |
dnkoutso
approved these changes
Oct 2, 2019
dnkoutso
force-pushed
the
segiddins/spec-json-round-trip
branch
from
e3f1f3a to
a549301
Compare
dnkoutso
added a commit
to dnkoutso/Core
that referenced
this pull request
Oct 3, 2019
…ashes during serialization.
dnkoutso
added a commit
to dnkoutso/Core
that referenced
this pull request
Oct 3, 2019
dnkoutso
added a commit
to dnkoutso/Core
that referenced
this pull request
Oct 4, 2019
dnkoutso
added a commit
to dnkoutso/Core
that referenced
this pull request
Oct 4, 2019
dnkoutso
added a commit
that referenced
this pull request
Oct 4, 2019
Follow up fix to #595 not to delete other hashes during serialization.
dnkoutso
added a commit
that referenced
this pull request
Oct 4, 2019
* 1-8-stable: [CHANGELOG] Add empty Master section Release 1.8.3 Follow up fix to #595 not to delete other hashes during serialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.