Expand use_frameworks! DSL to accept linkage style.
#581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
use_frameworks_linkage_dsl
branch
from
d5f6a30 to
a3c06f6
Compare
dnkoutso
changed the title
use_frameworks! DSL to accept linkage style.use_frameworks! DSL to accept linkage style.
dnkoutso
force-pushed
the
use_frameworks_linkage_dsl
branch
9 times, most recently
from
8be6999 to
e07f8f7
Compare
dnkoutso
force-pushed
the
use_frameworks_linkage_dsl
branch
from
e07f8f7 to
9bafc2f
Compare
dnkoutso
changed the title
use_frameworks! DSL to accept linkage style.use_frameworks! DSL to accept linkage style.
dnkoutso
force-pushed
the
use_frameworks_linkage_dsl
branch
7 times, most recently
from
aef2102 to
e910c68
Compare
dnkoutso
commented
Aug 19, 2019
| inheritance: search_paths | ||
| name: SampleAppTests | ||
| name: SampleApp | ||
| uses_frameworks: true |
There was a problem hiding this comment.
this is used for a test to ensure we can parse a pre-existing serialized YAML Podfile with a boolean value for uses_frameworks.
dnkoutso
force-pushed
the
use_frameworks_linkage_dsl
branch
from
e910c68 to
11e601f
Compare
dnkoutso
force-pushed
the
use_frameworks_linkage_dsl
branch
2 times, most recently
from
d58ad0d to
3cc6efb
Compare
paulb777
approved these changes
Aug 19, 2019
dnkoutso
force-pushed
the
use_frameworks_linkage_dsl
branch
4 times, most recently
from
8a7bbea to
e9372c7
Compare
dnkoutso
force-pushed
the
use_frameworks_linkage_dsl
branch
from
e9372c7 to
eb59870
Compare
dnkoutso
commented
Aug 21, 2019
| inheritance: search_paths | ||
| name: SampleAppTests | ||
| name: SampleApp | ||
| uses_frameworks: |
There was a problem hiding this comment.
likewise this is used to test that we can load uses_frameworks hash value from a serialized YAML Podfile.
amorde
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: CocoaPods/CocoaPods#9099