Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Source] Fix a crash when searching for compatible versions #528

Merged
merged 1 commit into from
Apr 22, 2019
Merged

[Source] Fix a crash when searching for compatible versions #528

merged 1 commit into from
Apr 22, 2019

Conversation

amorde
Copy link
Member

@amorde amorde commented Apr 14, 2019 •
edited
Loading

Closes #482

  • Fix Rubocop violations

@amorde amorde requested review from dnkoutso and segiddins April 14, 2019 03:19
@amorde amorde force-pushed the amorde/metadata-crash branch from d5620a8 to bad55c1 Compare April 14, 2019 22:30
segiddins
segiddins approved these changes Apr 15, 2019
View reviewed changes
lib/cocoapods-core/source/metadata.rb Outdated Show resolved Hide resolved
@dnkoutso dnkoutso added this to the 1.8 milestone Apr 19, 2019
@dnkoutso
Copy link
Contributor

@amorde needs rebase and comment update to land

@amorde
Copy link
Member Author

amorde commented Apr 19, 2019

Yup will try to get this in today

@dnkoutso dnkoutso removed this from the 1.8 milestone Apr 22, 2019
@dnkoutso
Copy link
Contributor

Quick ping on this would love to land it.

@dnkoutso
Copy link
Contributor

Also can be in 1-7-stable for 1.7.x release

@amorde amorde force-pushed the amorde/metadata-crash branch from bad55c1 to e14b358 Compare April 22, 2019 18:29
@amorde amorde changed the base branch from master to 1-7-stable April 22, 2019 18:29
@amorde amorde merged commit 562c7b3 into 1-7-stable Apr 22, 2019
@amorde amorde deleted the amorde/metadata-crash branch April 22, 2019 19:05
@amorde amorde mentioned this pull request Apr 26, 2019
Closed
@dnkoutso dnkoutso added this to the 1.7 milestone May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso approved these changes

@segiddins segiddins segiddins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@amorde @dnkoutso @segiddins