Extend script phase DSL to support execution position #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
commented
Oct 4, 2017
lib/cocoapods-core/podfile/dsl.rb
Outdated
| @@ -368,6 +368,10 @@ def target(name, options = nil) | |||
| # @option options [Boolean] :show_env_vars_in_log | |||
| # whether this script phase should output the environment variables during execution. | |||
| # | |||
| # @option options [Symbol] :execution_placement | |||
There was a problem hiding this comment.
Do you like :execution_placement? Would you prefer another word? I am not super happy but i cant find a better word.
There was a problem hiding this comment.
I've thought about it and re-thought about it again. I like it. Let's go with this instead.
dnkoutso
force-pushed
the
script_phase_execution_placement_dsl
branch
from
3551b64 to
1550382
Compare
dnkoutso
changed the title
|
Updated to use |
dnkoutso
force-pushed
the
script_phase_execution_placement_dsl
branch
2 times, most recently
from
6278f3d to
ff97759
Compare
dnkoutso
commented
Oct 4, 2017
| @parent.script_phases.should == [ | ||
| { :name => 'PhaseName', :script => 'echo "Hello World"', :shell_path => :'/usr/bin/ruby' }, |
There was a problem hiding this comment.
This was wrong :'/usr/bin/ruby' with the : added. Fixed.
dnkoutso
force-pushed
the
script_phase_execution_placement_dsl
branch
from
ff97759 to
d6518be
Compare
|
All green. |
dnkoutso
force-pushed
the
script_phase_execution_placement_dsl
branch
3 times, most recently
from
0b8b9c1 to
fd031ca
Compare
dnkoutso
force-pushed
the
script_phase_execution_placement_dsl
branch
from
fd031ca to
4ef270f
Compare
paulb777
approved these changes
Oct 4, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paulb777 I won't get into the habit of adding you as a reviewer. First of all thanks for your time on these and second it's only because you've reviewed the other PRs.