Correctly include parent dependencies when parsing testspecs #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
fix_test_specs_parsing
branch
from
848b17c to
8011a67
Compare
dnkoutso
commented
Jun 10, 2017
| @@ -879,7 +879,7 @@ def parse_subspecs(name, requirements) | |||
| end if test_specs | |||
|
|
|||
| requirements.pop if options.empty? | |||
| !subspecs.nil? || !test_specs.nil? | |||
There was a problem hiding this comment.
We should not include test specs here because if this method returns true then only the test specs are being parsed.
dnkoutso
commented
Jun 10, 2017
| @@ -234,13 +234,13 @@ module Pod | |||
|
|
|||
| it 'allows depending on testspecs' do | |||
| @parent.store_pod('RestKit', :testspecs => %w(Tests)) | |||
| @parent.dependencies.map(&:name).sort.should == %w(RestKit/Tests) | |||
| @parent.dependencies.map(&:name).sort.should == %w(RestKit RestKit/Tests) | |||
There was a problem hiding this comment.
Now this is correct! If I ask for the test spec 'Tests' I still want RestKit to be included.
orta
approved these changes
Jun 12, 2017
| @@ -234,13 +234,13 @@ module Pod | |||
|
|
|||
| it 'allows depending on testspecs' do | |||
| @parent.store_pod('RestKit', :testspecs => %w(Tests)) | |||
| @parent.dependencies.map(&:name).sort.should == %w(RestKit/Tests) | |||
| @parent.dependencies.map(&:name).sort.should == %w(RestKit RestKit/Tests) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now correct.