Fix Strange quotation marks in lockfile.rb

[dacaiguoguogmail]

Strange quotation marks in 'SPEC CHECKSUMS' section

SPEC CHECKSUMS:
  SDWebImage: '098e97e6176540799c27e804c96653ee0833d13c'

[orta]

I'm for this TBH, the quotes thing is an odd side-effect of different versions of the yaml writer between ruby versions that shouldn't affect reading I imagine.

[dacaiguoguogmail]

But the development team is not unified version of the situation is easy to appear, resulting in git log quotation marks appear and disappear, appear again, it is unnecessary and very troublesome.
Can you make yaml writer compatible with different ruby versions? Or given yaml writer compatible ruby version?

[orta]

Can you make yaml writer compatible with different ruby versions? Or given yaml writer compatible ruby version?

IMO - this is what your PR does 👍

[dacaiguoguogmail]

So should my PR be accepted?

[orta]

Yes, that is what I said I was in favour of, and it looks like @dnkoutso is too from the other PR

[dnkoutso]

@dacaiguoguogmail why couldnt we just always do something like:

yaml_string.tr("'", '')

Instead?

Yes I think we can merge this generally.

[dacaiguoguogmail]

@dnkoutso good idea, new PR #382

[dnkoutso]

@dacaiguoguogmail there is no need to re-open a new PR for each attempt to land this. It makes it harder to come back to and read any comments or thoughts during landing this.

[dnkoutso]

This looks good to me and harmless. Will wait tomorrow to merge it.

[dnkoutso]

Actually will wait until 1.3.0.beta.1 is out and then move it for beta.2

[dnkoutso]

@dacaiguoguogmail can you please rebase and squash your branch so we can land this?

[dacaiguoguogmail]

@dnkoutso rebase has been completed

[dnkoutso]

@dacaiguoguogmail this is still not right. Can you please squash to a single commit?

[dacaiguoguogmail]

1.I rebase and squash to a single commit in local branch
2.then I git pull, lead to a merge commit
3.git push
How do I deal with this? @dnkoutso

[dacaiguoguogmail]

@dnkoutso, I use git push --force fix it