Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Specification::DSL] Remove docset_url attribute #288

Merged
merged 3 commits into from
Dec 30, 2015
Merged

[Specification::DSL] Remove docset_url attribute #288

merged 3 commits into from
Dec 30, 2015

Conversation

segiddins
Copy link
Member

Closes #284

segiddins added a commit that referenced this pull request Dec 30, 2015
@segiddins
Merge pull request #288 from CocoaPods/seg-spec-remove-docset-url
0c38606 
[Specification::DSL] Remove docset_url attribute
@segiddins segiddins merged commit 0c38606 into master Dec 30, 2015
@segiddins segiddins deleted the seg-spec-remove-docset-url branch December 30, 2015 09:11
@orta
Copy link
Member

orta commented Dec 30, 2015

If I use a spec from trunk that included documentation_url it would work fine right?

@segiddins
Copy link
Member Author

documentation_url is still there :) but yeah, since trunk is json, removing an attribute will have 0 effect on those specs

@orta
Copy link
Member

orta commented Dec 30, 2015

👍

@alexanderdean alexanderdean mentioned this pull request Jan 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@segiddins @orta