Change required activesupport version to >=4.0.2 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoking `plugin` in a Podfile calls `Hash.deep_stringify_keys` (http://apidock.com/rails/v4.0.2/Hash/deep_stringify_keys), which was first added to activesupport in version 4.0.2. As noted in Cocoapods/Core#3076, the base activesupport version was held back to continue support for versions of Ruby before 2.0.0. As of 76845c8, Cocoapods no longer supports Ruby versions less than 2.0, invalidating the reasoning for holding back the base version number.
kylef
added a commit
that referenced
this pull request
Sep 23, 2015
…pendency Change required activesupport version to >=4.0.2
|
Thanks @kattrali 🎈. |
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
…untime-dependency Change required activesupport version to >=4.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user only has activesupport 3.2.15 installed, invoking
pluginin a Podfile callsHash.deep_stringify_keyscausing a crash.deep_stringify_keyswas first added to activesupport in version 4.0.2, but the base version required by core is 3.2.15. As noted in the comments on CocoaPods/CocoaPods#2307, the base activesupport version was held back to continue support for versions of Ruby before 2.0.0.As of 76845c8, Cocoapods no longer supports Ruby versions less than 2.0, invalidating the reasoning for holding back the base version number.