Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvos as a new platform #263

Merged
merged 3 commits into from
Sep 24, 2015
Merged

Add tvos as a new platform #263

merged 3 commits into from
Sep 24, 2015

Conversation

neonichu
Copy link
Member

No description provided.

neonichu added a commit that referenced this pull request Sep 10, 2015
@neonichu
Copy link
Member Author

cc @segiddins

#
# If the deployment target requires it (iOS < `4.3`), `armv6`
# architecture will be added to `ARCHS`.
#
# @param [Symbol] name
# the name of platform, can be either `:osx` for OS X, `:ios`
# for iOS or `:watchos` for watchOS.
# for iOS, `:tvos` for tvOS or `:watchos` for watchOS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oxford comma

@segiddins
Copy link
Member

❤️

@aufflick
Copy link

FYI If you specify :tvos as the platform in Podfile (as opposed to podspec or the xcodeproj) you get:

[!] Invalid `Podfile` file: Unsupported platform `tvos`. Platform must be `:ios`, `:osx`, or `:watchos`.. Updating CocoaPods might fix the issue.

@orta
Copy link
Member

orta commented Sep 12, 2015

@aufflick you got all the gems in the Gemfile?

@aufflick
Copy link

Here's my Gemfile:

source 'https://rubygems.org'

gem 'cocoapods', :git => 'https://github.com/CocoaPods/CocoaPods.git', :branch => 'tvos'
gem 'xcodeproj', :git => 'https://github.com/CocoaPods/Xcodeproj.git', :branch => 'tvos-support'

gem 'cocoapods-keys', :git => 'https://github.com/orta/cocoapods-keys.git'

gem 'xcpretty'
gem 'shenzhen'
gem 'sbconstants'

@neonichu
Copy link
Member Author

@aufflick you're missing:

gem 'cocoapods-core', :git => 'https://github.com/CocoaPods/Core.git', :branch => 'tvos-support'

@aufflick
Copy link

Yes, I just noticed that - things have changed since I last built from source :)

I still see the problem though :(

[!] Invalid `Podfile` file: Unsupported platform `tvos`. Platform must be `:ios`, `:osx`, or `:watchos`.. Updating CocoaPods might fix the issue.

 #  from /Users/aufflick/src/Foo/Podfile:10
 #  -------------------------------------------
 #  target 'Foo' do
 >    platform :tvos, '9.0'
 #  
 #  -------------------------------------------

Gemfile:

source 'https://rubygems.org'

gem 'cocoapods', :git => 'https://github.com/CocoaPods/CocoaPods.git', :branch => 'tvos'
gem 'cocoapods-core', :git => 'https://github.com/CocoaPods/Core.git', :branch => 'tvos-support'
gem 'xcodeproj', :git => 'https://github.com/CocoaPods/Xcodeproj.git', :branch => 'tvos-support'

gem 'cocoapods-keys'
gem 'cocoapods-deintegrate'

@neonichu
Copy link
Member Author

hm, not sure — I'm OSS'ing a tvOS project today, then you can compare :)

@aufflick
Copy link

Gah, this time I forgot to bundle exec - working now. Thanks @neonichu, thanks @orta.

@aufflick
Copy link

BTW: the Gemfile guide is out of date: http://guides.cocoapods.org/using/a-gemfile.html

@orta
Copy link
Member

orta commented Sep 14, 2015

How so?

@segiddins
Copy link
Member

@neonichu :shipit: with a rebase

neonichu added a commit that referenced this pull request Sep 24, 2015
@neonichu neonichu merged commit 9cc7744 into master Sep 24, 2015
@neonichu neonichu deleted the tvos-support branch September 24, 2015 22:18
@quentinfasquel
Copy link

So is there a proper way to already have a Podfile that specify dependencies for a :tvos target?
What's the full process? Thank you

@neonichu
Copy link
Member Author

You can see an example project here: https://github.com/contentful/tvful — basically, you need a Gemfile, as discussed in https://guides.cocoapods.org/using/unreleased-features

@quentinfasquel
Copy link

Awesome thank you!

Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants