Merge pull request #603 from dnkoutso/code_coverage_scheme

Add `code_coverage` support for scheme DSL.
CocoaPods · Oct 29, 2019 · fe19e73 · fe19e73
2 parents 088b3ae + 2f147b9
commit fe19e73
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,11 @@
 
 ##### Enhancements
 
+* Add `code_coverage` support for scheme DSL.  
+  [Dimitris Koutsogiorgas](https://github.com/dnkoutso)
+  [#603](https://github.com/CocoaPods/Core/pull/603)
+  [CocoaPods/CocoaPods#8921](https://github.com/CocoaPods/CocoaPods/issues/8921)
+
 * Add `:configurations` DSL for podspec dependencies.  
   [Samuel Giddins](https://github.com/segiddins)
   [Dimitris Koutsogiorgas](https://github.com/dnkoutso)

diff --git a/lib/cocoapods-core/specification/dsl.rb b/lib/cocoapods-core/specification/dsl.rb
@@ -1596,7 +1596,7 @@ def subspec(name, &block)
                 :types => [String],
                 :spec_types => [:test]
 
-      SCHEME_KEYS = [:launch_arguments, :environment_variables].freeze
+      SCHEME_KEYS = [:launch_arguments, :environment_variables, :code_coverage].freeze
 
       # @!method scheme=(flag)
       #

diff --git a/lib/cocoapods-core/specification/linter.rb b/lib/cocoapods-core/specification/linter.rb
@@ -450,6 +450,9 @@ def _validate_scheme(s)
           if s.key?(:environment_variables) && !s[:environment_variables].is_a?(Hash)
             results.add_error('scheme', 'Expected a hash for key `environment_variables`.')
           end
+          if s.key?(:code_coverage) && ![true, false].include?(s[:code_coverage])
+            results.add_error('scheme', 'Expected a boolean for key `code_coverage`.')
+          end
         end
       end
 

diff --git a/spec/specification/linter_spec.rb b/spec/specification/linter_spec.rb
@@ -546,7 +546,8 @@ def result_should_include(*values)
       #------------------#
 
       it 'accepts valid scheme values' do
-        @spec.scheme = { :launch_arguments => ['Arg1'], :environment_variables => { 'Key1' => 'Val1' } }
+        @spec.scheme = { :launch_arguments => ['Arg1'], :environment_variables => { 'Key1' => 'Val1' },
+                         :code_coverage => true }
         @linter.lint
         @linter.results.should.be.empty
       end
@@ -561,6 +562,11 @@ def result_should_include(*values)
         result_should_include('scheme', 'Expected a hash for key `environment_variables`.')
       end
 
+      it 'checks scheme code coverage key type' do
+        @spec.scheme = { :code_coverage => 1 }
+        result_should_include('scheme', 'Expected a boolean for key `code_coverage`.')
+      end
+
       #------------------#
 
       it 'accepts valid frameworks' do