Merge pull request #535 from dnkoutso/cp_fun

Cherry-pick #504 to 1.6.x

CHANGELOG.md

@@ -8,7 +8,9 @@
 
 ##### Bug Fixes
 
-* None.  
+* Ensure `test_type` value is converted to a symbol from consumers of JSON podspecs.  
+  [Dimitris Koutsogiorgas](https://github.com/dnkoutso)
+  [#504](https://github.com/CocoaPods/Core/pull/504)
 
 
 ## 1.6.1 (2019-02-21)

lib/cocoapods-core/specification/consumer.rb

@@ -371,6 +371,19 @@ def _prepare_prefix_header_contents(value)
         end
       end
 
+      # Converts the test type value from a string to a symbol.
+      #
+      # @param  [String, Symbol] value.
+      #         The value of the test type attributed as specified by the user.
+      #
+      # @return [Symbol] the test type as a symbol.
+      #
+      def _prepare_test_type(value)
+        if value
+          value.to_sym
+        end
+      end
+
       # Converts the array of hashes (script phases) where keys are strings into symbols.
       #
       # @param  [Array<Hash{String=>String}>] value.

spec/specification/consumer_spec.rb

@@ -272,6 +272,15 @@ module Pod
         test_consumer.test_type.should.be == :unit
       end
 
+      it 'returns the test type as a symbol when consuming JSON specs' do
+        @spec.test_spec {}
+        test_spec = @spec.test_specs.first
+        test_spec.test_type = :unit
+        json_spec = @spec.to_json
+        test_consumer = Specification::Consumer.new(Specification.from_json(json_spec).test_specs.first, :ios)
+        test_consumer.test_type.should.be == :unit
+      end
+
       it 'allows to specify whether the specification requires an app host' do
         @spec.test_spec {}
         test_spec = @spec.test_specs.first