DDFileLogger: adding logFilesDiskQuota property. Fixes #195
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -106,6 +109,7 @@ - (void)dealloc | |||
| // try-catch because the observer might be removed or never added. In this case, removeObserver throws and exception | |||
| @try { | |||
| [self removeObserver:self forKeyPath:NSStringFromSelector(@selector(maximumNumberOfLogFiles))]; | |||
| [self removeObserver:self forKeyPath:NSStringFromSelector(@selector(logFilesDiskQuota))]; | |||
There was a problem hiding this comment.
Maybe it would be cleaner if we override setLogFilesDiskQuota instead of using KVO?
There was a problem hiding this comment.
Yes, it would be cleaner. I just tried to adjust to existing code. Someone knows, why KVO is used for maximumNumberOfLogFiles? Any thoughts?
There was a problem hiding this comment.
I guess there would be some comment explaining the choice if KVO was really needed.
Let's merge it for now and we can discuss this in another pull request.
rivera-ernesto
pushed a commit
that referenced
this pull request
Jul 2, 2014
DDFileLogger: adding `logFilesDiskQuota` property. Fixes #195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now users have an option to set disk quota for log files. 20 MB is used by default, which seems enough.