Allow user-defined network settings via NetworkDefinitions.local.ini #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
|
SadPencil
approved these changes
Feb 10, 2025
SadPencil
changed the title
|
Thank you for implementing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #653
Adds check for NetworkDefinitions.local.ini
The changes in PreStartup.cs are to fix the logging as the network definitions were loaded before the initial log file outputs.
So instead of:
10.02. 10:25:54.356 Loaded network definitions from NetworkDefinitions.local.ini (user override)
10.02. 10:25:54.361 Logfile for Yuri's Revenge client
10.02. 10:25:54.387 Client version: 2025-02-05 develop@f11f56f
10.02. 10:25:54.387 2.11.0-beta.199+Branch.develop.Sha.f11f56f5a80f141faa998cf3566948afe5021d1c
10.02. 10:25:54.388 This is a development build of the client. Stability and reliability may not be fully guaranteed.
10.02. 10:25:54.389 Loading settings.
It will show:
10.02. 10:32:12.032 Logfile for CnCNet Client client
10.02. 10:32:12.059 Client version: 2025-02-05 develop@f11f56f
10.02. 10:32:12.060 2.11.0-beta.199+Branch.develop.Sha.f11f56f5a80f141faa998cf3566948afe5021d1c
10.02. 10:32:12.068 This is a development build of the client. Stability and reliability may not be fully guaranteed.
10.02. 10:32:12.087 Loaded network definitions from NetworkDefinitions.local.ini (user override)
10.02. 10:32:12.092 Loading settings.