Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of messages containing ACTION #660

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

11EJDE11
Copy link
Contributor

@11EJDE11 11EJDE11 commented Feb 7, 2025

Currently any chat message containing "ACTION" will get handled incorrectly.

I assume this was a debugging thing from years ago and can be removed completely. Alternatively we could change it to StartsWith u0001 + "ACTION".

Can anyone reviewing this also check the two instances of ACTION here as I think they can be removed too?

if (parameters.Count > 1 && Convert.ToInt32(parameters[1][0]) == 1 && !parameters[1].Contains("ACTION"))

Copy link

github-actions bot commented Feb 7, 2025

Nightly build for this pull request:

@Rampastring
Copy link
Member

Rampastring commented Feb 7, 2025

The client used to have notifications like <player> has hosted a new <game> game, like 11EJDE11 has hosted a new Tiberian Sun game. FunkyFr3sh's CnCNet client used to broadcast these with ACTIONs, so this was done to have better compatibility with his client.

I can't recall seeing these messages in years though, so FF possibly changed his logic at some point, meaning this can likely be removed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants