Fix: ra: Prevent to add unknown operation (bsc#1236442) #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
liangxin1300
commented
Jan 27, 2025
liangxin1300
commented
- When adding unknown operation, sanity check should give an error instead of a warning
- And sanity check will return a big number to indicate this is a fatal error, so that the commit process will be aborted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
liangxin1300
changed the title
- When adding unknown operation, sanity check should give an error instead of a warning - And sanity check will return a big number to indicate this is a fatal error, so that the commit process will be aborted
liangxin1300
force-pushed
the
20250113_prevent_unknown_op
branch
from
5d54ee1 to
b7c15db
Compare
| @@ -744,6 +744,8 @@ def _verify(self, set_obj_semantic, set_obj_all): | |||
| rc1 = set_obj_all.verify() | |||
| if config.core.check_frequency != "never": | |||
| rc2 = set_obj_semantic.semantic_check(set_obj_all) | |||
| if rc2 >= constants.SANITY_FATAL_RC: | |||
| cib_factory.reset() | |||
There was a problem hiding this comment.
I think reset() should not be called here.
_verify()is also called fromdo_verify(). This subcommand should not have a side effect.- Even when called from
_commit(), it is enough to abort the commit, so that users will have a chance to modify their config instead of losing all the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.