Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Fix: ui_cluster: Stop renaming cluster name when using qdevice #1576

Conversation

liangxin1300
Copy link
Collaborator

backport from #1573

Give user a hint that the cluster name should not be renamed when using
qdevice, should remove qdevice first.

And also automatically restart cluster when there is no any resource
running, when renaming the cluster name.

Fix issue ClusterLabs#1465
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.27%. Comparing base (df8b180) to head (3f87b5a).

Files with missing lines Patch % Lines
crmsh/ui_cluster.py 9.09% 10 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 52.98% <42.10%> (-0.02%) ⬇️
unit 49.67% <42.10%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 84.61% <100.00%> (+0.01%) ⬆️
crmsh/qdevice.py 98.76% <100.00%> (-0.01%) ⬇️
crmsh/sbd.py 91.94% <100.00%> (-0.05%) ⬇️
crmsh/ui_cluster.py 74.81% <9.09%> (-1.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review October 11, 2024 02:00
@liangxin1300 liangxin1300 merged commit fac7d0c into ClusterLabs:crmsh-4.6 Oct 11, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants