Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: ui_context: Skip querying CIB when in a sublevel or help command #1403

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Dev: ui_context: Skip querying CIB when in a sublevel or help command #1403

merged 2 commits into from
Apr 25, 2024

Conversation

liangxin1300
Copy link
Collaborator

port from #1300

@liangxin1300
Dev: ui_context: Skip querying CIB when in a sublevel or help command
beb26f3 
When cluster service is not running, entering some crm sublevel requires live cib,
and it will fail to show the help info under this sublevel;
To fix that, should skip querying cib when the current stack is just a sublevel,
or when the current command is the non functional command (like help, ls, cd, up, quit)
@liangxin1300
Dev: behave: Add functional test for previous change
c480afc
@codecov Codecov
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.66%. Comparing base (4360523) to head (c480afc).

Files Patch % Lines
crmsh/ui_context.py 55.55% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1403      +/-   ##
==========================================
+ Coverage   53.53%   53.66%   +0.12%     
==========================================
  Files          80       80              
  Lines       23926    23932       +6     
==========================================
+ Hits        12809    12842      +33     
+ Misses      11117    11090      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 merged commit e18847d into ClusterLabs:master Apr 25, 2024
30 checks passed
@liangxin1300 liangxin1300 mentioned this pull request Jun 18, 2024
Closed
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jun 21, 2024
Fix: crm cluster delete autocomplete ClusterLabs#1403 ClusterLabs#1460
052ea58
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jun 21, 2024
Fix: crm cluster delete autocomplete ClusterLabs#1403 ClusterLabs#1460
d7e97d9
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jun 21, 2024
Fix: crm cluster delete autocomplete ClusterLabs#1403 ClusterLabs#1460
2be2395
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jun 21, 2024
Fix: ui_context: crm cluster delete autocomplete ClusterLabs#1403 Clu…
3459d73 
…sterLabs#1460

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jun 21, 2024
Fix: ui_context: crm cluster delete autocompletion ClusterLabs#1403 C…
2c856c3 
…lusterLabs#1460

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jun 25, 2024
Fix: ui_context: crm cluster delete autocompletion ClusterLabs#1403 C…
5be7bb6 
…lusterLabs#1460

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jun 25, 2024
Fix: ui_context: crm cluster delete autocompletion ClusterLabs#1403 C…
15ec6c2 
…lusterLabs#1460

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jun 25, 2024
Fix: ui_context: crm cluster delete autocompletion ClusterLabs#1403 C…
d1c3657 
…lusterLabs#1460

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
@liangxin1300 liangxin1300 mentioned this pull request Jun 26, 2024
Merged
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jun 27, 2024
Fix: ui_context: crm cluster delete autocompletion ClusterLabs#1403 C…
3812503 
…lusterLabs#1460

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
liangxin1300 added a commit that referenced this pull request Jun 28, 2024
@liangxin1300
Fix: ui_context: crm configure delete autocompletion #1403 #1460 (#1469)
3b3d7ee 
If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jul 1, 2024
Fix: ui_context: crm cluster delete autocompletion ClusterLabs#1403 C…
929d1a8 
…lusterLabs#1460

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jul 1, 2024
[crmsh-4.6] Fix: ui_context: crm cluster delete autocompletion Cluste…
8dc3979 
…rLabs#1403 ClusterLabs#1460

backport ClusterLabs#1469

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
liangxin1300 added a commit that referenced this pull request Jul 1, 2024
@liangxin1300
[crmsh-4.6] Fix: ui_context: crm cluster delete autocompletion #1403 #…
10f6f91 
…1460 (#1480)

backport #1469

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasyang2022 nicholasyang2022 nicholasyang2022 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangxin1300 @nicholasyang2022