[crmsh-4.6] Fix: ui_node: When utils.list_cluster_nodes return None, try to get ip list from corosync.conf
#1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ip list from corosync.conf PR#1312 try to fix the issue that `crm cluster start --all` failed when there is no CIB, but it also break what `list_cluster_nodes` returns, which is widely used in crmsh and will cause many other unexpected issues. This patch fix that regression by calling `utils.get_address_list_from_corosync_conf` after `utils.list_cluster_nodes` return None when parsing node args.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## crmsh-4.6 #1378 +/- ##
==========================================
Coverage 52.85% 52.85%
==========================================
Files 79 79
Lines 23952 23955 +3
==========================================
+ Hits 12659 12661 +2
- Misses 11293 11294 +1 ☔ View full report in Codecov by Sentry. |
nicholasyang2022
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #1377