[crmsh-4.6] Fix: add diagnostic messages when crm report cannot find ssh-agent (bsc#1219538) #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sc#1219538) In a cluster boostrapped with `--use-ssh-agent`, crm report depends on the agent to authenticate to other nodes. If the agent is not started, forwarded or is hidden by sudo, crmsh should print diagnostic message to help users fix the problem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## crmsh-4.6 #1336 +/- ##
==========================================
Coverage 52.82% 52.82%
==========================================
Files 79 79
Lines 24002 24002
==========================================
Hits 12678 12678
Misses 11324 11324 ☔ View full report in Codecov by Sentry. |
|
Outputs with this patch applied: |
liangxin1300
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a cluster boostrapped with
--use-ssh-agent, crm report depends on the agent to authenticate to other nodes. If the agent is not started, forwarded or is hidden by sudo, crmsh should print diagnostic message to help users fix the problem.