Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Fix: ui_node: clearstate command needs adjustment (bsc#1219831) #1334

Conversation

aleksei-burlakov
Copy link
Contributor

"crm node show" and "clearstate" commands need adjustments. The format of the output in the //node_state has little changed in ClusterLabs/pacemaker#3031 This PR enables the crmsh to understand both the new and the old format.

[crmsh-4.6] Backport #1323

"crm node show" and "clearstate" commands need adjustments.
The format of the output in the //node_state has little changed in
ClusterLabs/pacemaker#3031
This PR enables the crmsh understand both the new and the old format.

[crmsh-4.6] Backport ClusterLabs#1323
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1ffead1) 52.68% compared to head (c5e6b78) 52.68%.

Files Patch % Lines
crmsh/ui_node.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           crmsh-4.6    #1334      +/-   ##
=============================================
- Coverage      52.68%   52.68%   -0.01%     
=============================================
  Files             79       79              
  Lines          23987    23989       +2     
=============================================
  Hits           12638    12638              
- Misses         11349    11351       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 changed the title Fix: ui_node: clearstate command needs adjustment (bsc#1219831) [crmsh-4.6] Fix: ui_node: clearstate command needs adjustment (bsc#1219831) Feb 20, 2024
Copy link
Collaborator

@liangxin1300 liangxin1300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work
Thanks @aleksei-burlakov !

@liangxin1300 liangxin1300 merged commit 9101383 into ClusterLabs:crmsh-4.6 Feb 20, 2024
30 of 31 checks passed
@aleksei-burlakov aleksei-burlakov deleted the do-clearstate-backport-crmsh4.6 branch July 8, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants