Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: ui_utils: Supports '=' when setting node/resource attributes #1265

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Dev: ui_utils: Supports '=' when setting node/resource attributes #1265

merged 2 commits into from
Nov 13, 2023

Conversation

liangxin1300
Copy link
Collaborator

Now supports both:

crm node attribute <node> set <attr> <value>
crm node attribute <node> set <attr>=<value>

crm resource meta <rsc> set <attr> <value>
crm resource meta <rsc> set <attr>=<value>

crm resource param <rsc> set <param> <value>
crm resource param <rsc> set <param>=<value>

@liangxin1300
Dev: ui_utils: Supports '=' when setting node/resource attributes
c81f3cc 
Now supports both:
crm node attribute <node> set <attr> <value>
crm node attribute <node> set <attr>=<value>

crm resource meta <rsc> set <attr> <value>
crm resource meta <rsc> set <attr>=<value>

crm resource param <rsc> set <param> <value>
crm resource param <rsc> set <param>=<value>
@liangxin1300 liangxin1300 mentioned this pull request Nov 1, 2023
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

Merging #1265 (2f0c417) into master (2d66012) will decrease coverage by 0.04%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   53.01%   52.97%   -0.04%     
==========================================
  Files          79       79              
  Lines       25065    25067       +2     
==========================================
- Hits        13287    13279       -8     
- Misses      11778    11788      +10
Files Coverage Δ
crmsh/ui_utils.py 53.15% <100.00%> (+0.85%) ⬆️

... and 1 file with indirect coverage changes

@liangxin1300 liangxin1300 requested a review from zzhou1 November 13, 2023 03:38
@liangxin1300 liangxin1300 force-pushed the 20231101_compat_node_resource_set branch from 4bd27f1 to 2f0c417 Compare November 13, 2023 06:52
@liangxin1300 liangxin1300 merged commit 4095895 into ClusterLabs:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzhou1 zzhou1 zzhou1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangxin1300 @zzhou1