Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian/watch: Look at tags instead of releases #215

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

df7cb
Copy link
Contributor

@df7cb df7cb commented Oct 7, 2022

The old URL doesn't work with uscan(1) anymore.

@ioguix
Copy link
Member

ioguix commented Oct 13, 2022

Hi Christoph,

If I understand correctly, the new url will produce a package for any new tags pushed in this repo?

@df7cb
Copy link
Contributor Author

df7cb commented Oct 14, 2022

Almost, but not quite. The tag still needs to start with v, and the version number in debian/changelog needs to point at that tag. This change just fixes the ability to see the tags as versions. (Github changed the layout of the /releases pages so uscan didn't see anything at all anymore.)

$ uscan --verbose
uscan info: uscan (version 2.22.2) See uscan(1) for help
uscan info: Scan watch files in .
uscan info: Check debian/watch and debian/changelog in .
uscan info: package="resource-agents-paf" version="2.3.0-1" (as seen in debian/changelog)
uscan info: package="resource-agents-paf" version="2.3.0" (no epoch/revision)
uscan info: ./debian/changelog sets package="resource-agents-paf" version="2.3.0"
uscan info: Process watch file at: debian/watch
    package = resource-agents-paf
    version = 2.3.0
    pkg_dir = .
uscan info: opts: filenamemangle=s/.+\/v?(\d\S+)\.tar\.gz/PAF-$1\.tar\.gz/,uversionmangle=s/_beta/~beta/;s/_alpha/~alpha/;s/_rc/~rc/
uscan info: line: https://github.com/ClusterLabs/PAF/releases .*/v?(\d\S+)\.tar\.gz
uscan info: Parsing filenamemangle=s/.+\/v?(\d\S+)\.tar\.gz/PAF-$1\.tar\.gz/
uscan info: Parsing uversionmangle=s/_beta/~beta/;s/_alpha/~alpha/;s/_rc/~rc/
uscan info: line: https://github.com/ClusterLabs/PAF/releases .*/v?(\d\S+)\.tar\.gz
uscan info: Last orig.tar.* tarball version (from debian/changelog): 2.3.0
uscan info: Last orig.tar.* tarball version (dversionmangled): 2.3.0
uscan info: Requesting URL:
   https://github.com/ClusterLabs/PAF/releases
uscan info: Matching pattern:
   (?:(?:https://github.com)?\/ClusterLabs\/PAF\/)?.*/v?(\d\S+)\.tar\.gz
uscan warn: In debian/watch no matching files for watch line
  https://github.com/ClusterLabs/PAF/releases .*/v?(\d\S+)\.tar\.gz
uscan info: Scan finished

With the fix:

$ uscan --verbose
uscan info: uscan (version 2.22.2) See uscan(1) for help
uscan info: Scan watch files in .
uscan info: Check debian/watch and debian/changelog in .
uscan info: package="resource-agents-paf" version="2.3.0-1" (as seen in debian/changelog)
uscan info: package="resource-agents-paf" version="2.3.0" (no epoch/revision)
uscan info: ./debian/changelog sets package="resource-agents-paf" version="2.3.0"
uscan info: Process watch file at: debian/watch
    package = resource-agents-paf
    version = 2.3.0
    pkg_dir = .
uscan info: opts: filenamemangle=s/.+\/v?(\d\S+)\.tar\.gz/PAF-$1\.tar\.gz/,uversionmangle=s/_beta/~beta/;s/_alpha/~alpha/;s/_rc/~rc/
uscan info: line: https://github.com/ClusterLabs/PAF/tags .*/v?(\d\S+)\.tar\.gz
uscan info: Parsing filenamemangle=s/.+\/v?(\d\S+)\.tar\.gz/PAF-$1\.tar\.gz/
uscan info: Parsing uversionmangle=s/_beta/~beta/;s/_alpha/~alpha/;s/_rc/~rc/
uscan info: line: https://github.com/ClusterLabs/PAF/tags .*/v?(\d\S+)\.tar\.gz
uscan info: Last orig.tar.* tarball version (from debian/changelog): 2.3.0
uscan info: Last orig.tar.* tarball version (dversionmangled): 2.3.0
uscan info: Requesting URL:
   https://github.com/ClusterLabs/PAF/tags
uscan info: Matching pattern:
   (?:(?:https://github.com)?\/ClusterLabs\/PAF\/)?.*/v?(\d\S+)\.tar\.gz
uscan info: Found the following matching hrefs on the web page (newest first):
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3.0.tar.gz (2.3.0) index=2.3.0-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3.0.tar.gz (2.3.0) index=2.3.0-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3_rc2.tar.gz (2.3~rc2) index=2.3~rc2-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3_rc2.tar.gz (2.3~rc2) index=2.3~rc2-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3_rc1.tar.gz (2.3~rc1) index=2.3~rc1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3_rc1.tar.gz (2.3~rc1) index=2.3~rc1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2_181fce26.tar.gz (2.2_181fce26) index=2.2_181fce26-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2_181fce26.tar.gz (2.2_181fce26) index=2.2_181fce26-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2.1.tar.gz (2.2.1) index=2.2.1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2.1.tar.gz (2.2.1) index=2.2.1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2.1_rc1.tar.gz (2.2.1~rc1) index=2.2.1~rc1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2.1_rc1.tar.gz (2.2.1~rc1) index=2.2.1~rc1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2.0.tar.gz (2.2.0) index=2.2.0-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2.0.tar.gz (2.2.0) index=2.2.0-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2_rc1.tar.gz (2.2~rc1) index=2.2~rc1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2_rc1.tar.gz (2.2~rc1) index=2.2~rc1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2_beta1.tar.gz (2.2~beta1) index=2.2~beta1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.2_beta1.tar.gz (2.2~beta1) index=2.2~beta1-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v1.1.0.tar.gz (1.1.0) index=1.1.0-1 
   https://github.com/ClusterLabs/PAF/archive/refs/tags/v1.1.0.tar.gz (1.1.0) index=1.1.0-1 
uscan info: Looking at $base = https://github.com/ClusterLabs/PAF/tags with
    $filepattern = .*/v?(\d\S+)\.tar\.gz found
    $newfile     = https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3.0.tar.gz
    $newversion  = 2.3.0
    $lastversion = 2.3.0
uscan info: Matching target for downloadurlmangle: https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3.0.tar.gz
uscan info: Upstream URL(+tag) to download is identified as    https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3.0.tar.gz
uscan info: Matching target for filenamemangle: https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3.0.tar.gz
uscan info: Filename (filenamemangled) for downloaded file: PAF-2.3.0.tar.gz
uscan info: Newest version of resource-agents-paf on remote site is 2.3.0, local version is 2.3.0
uscan info:  => Package is up to date from:
             => https://github.com/ClusterLabs/PAF/archive/refs/tags/v2.3.0.tar.gz
uscan info: Scan finished

@ioguix
Copy link
Member

ioguix commented Oct 18, 2022

Oh, OK, great ! Thank you for the explanations and the fix!

@ioguix ioguix merged commit d191e09 into ClusterLabs:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants