Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

build: docker image #16

Merged
merged 6 commits into from
Jul 29, 2020
Merged

build: docker image #16

merged 6 commits into from
Jul 29, 2020

Conversation

l3uddz
Copy link
Member

@l3uddz l3uddz commented Jul 28, 2020

Create docker images.

master

The latest commit to master

latest

The latest github version tag / release

An accompanying tag will also be created with the GitHub tag, e.g. v1.0.0

other docker tags

Branches and pull requests will have an image created.

Tags with sha short commits will be created.

@l3uddz l3uddz added build Affects the build system or dependencies: go.mod, makefile ci Specifically targets Github Actions labels Jul 28, 2020
@l3uddz l3uddz requested a review from m-rots July 28, 2020 19:33
@m-rots m-rots added this to the Early Access Preview milestone Jul 28, 2020
Copy link
Collaborator

@m-rots m-rots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how it works but I trust you on this one

@m-rots m-rots changed the title feat(Docker): docker image build: docker image Jul 28, 2020
@m-rots m-rots requested a review from horjulf July 28, 2020 19:43
@l3uddz
Copy link
Member Author

l3uddz commented Jul 28, 2020

@horjulf able to review this and make following improvement:

  • latest docker tag = latest GitHub version tag.
  • master docker tag = latest master commit

Thanks!!

@horjulf
Copy link

horjulf commented Jul 28, 2020

Add a .dockerignore so it doesn't have to copy the full context every time.

e.g.

*
!build/
!dist/

@m-rots m-rots self-requested a review July 28, 2020 22:30
.github/workflows/build.yml Outdated Show resolved Hide resolved
@m-rots m-rots merged commit 8ccff89 into master Jul 29, 2020
@m-rots m-rots deleted the docker branch July 29, 2020 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Affects the build system or dependencies: go.mod, makefile ci Specifically targets Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants