Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isort all .py files #214

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Isort all .py files #214

merged 6 commits into from
Dec 15, 2023

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Dec 14, 2023

This PR adds | fixes:

  • Run isort on the entire repo. I've realised that the feature was not set in my pycharm settings for this repo

How to test:

  • No test needed, just reformat

Review:

  • Code approved by HS
  • Tests executed by CR

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (0e7ab7e) 95.14% compared to head (c46597f) 96.47%.
Report is 402 commits behind head on main.

Files Patch % Lines
src/chanjo2/meta/handle_report_contents.py 89.06% 14 Missing ⚠️
src/chanjo2/crud/samples.py 83.33% 3 Missing ⚠️
src/chanjo2/models/pydantic_models.py 98.05% 2 Missing ⚠️
src/chanjo2/dbutil.py 66.66% 1 Missing ⚠️
src/chanjo2/endpoints/coverage.py 96.42% 1 Missing ⚠️
tests/src/chanjo2/crud/test_crud_intervals.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   95.14%   96.47%   +1.33%     
==========================================
  Files          25       34       +9     
  Lines        1462     1959     +497     
==========================================
+ Hits         1391     1890     +499     
+ Misses         71       69       -2     
Flag Coverage Δ
unittests 96.47% <97.08%> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@northwestwitch northwestwitch merged commit 6fe9cbe into main Dec 15, 2023
7 checks passed
@northwestwitch northwestwitch deleted the isort_libs branch January 17, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants