-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Strelka and Mutect2 from somatic variant calling #513
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
cd921e5
remove strelka and mutect2
hassanfa 574785c
coveralls
hassanfa f82f67a
stepS
hassanfa cf7bc8e
test only for certain path
hassanfa d2154f8
refactor env
hassanfa 9335e93
remove cython
hassanfa ab8248a
coveralls version unlock
hassanfa b429664
remove --user from pip install
hassanfa 8b67f93
remove unused run
hassanfa dadf769
pip as module
hassanfa 631cf5a
remove activate
hassanfa 1e19100
put activate back
hassanfa 8d6be91
good old source activate instead of conda
hassanfa 2fa1146
login bash
hassanfa 39b2cf8
proper py.test
hassanfa a936b1b
test help
hassanfa 7e6a9ef
get germline dynamic
hassanfa 9ec33a8
remove unused lines
hassanfa 69f2188
replace coveralls with codecov
hassanfa 356d741
codecov simpler
hassanfa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,9 @@ on: | |
- develop | ||
tags-ignore: | ||
- "**" | ||
paths: | ||
- 'BALSAMIC/containers/**' | ||
|
||
|
||
jobs: | ||
main: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
name: PyTest and Coveralls | ||
|
||
on: ["push", "pull_request"] | ||
|
||
jobs: | ||
pytest_coveralls: | ||
name: run PyTest | ||
runs-on: ubuntu-18.04 | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: [3.6] | ||
|
||
steps: | ||
# Checkout BALSAMIC | ||
- name: Git checkout | ||
id: git_checkout | ||
uses: actions/checkout@v2 | ||
|
||
# Get branch name | ||
- name: Get branch name | ||
id: get_branch_name | ||
shell: bash | ||
run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF##*/})" | ||
|
||
# Conda env create | ||
- name: setup conda | ||
id: setup_conda | ||
uses: conda-incubator/setup-miniconda@v2 | ||
with: | ||
activate-environment: balsamic | ||
environment-file: BALSAMIC/conda/balsamic.yaml | ||
python-version: ${{ matrix.python-version }} | ||
|
||
# Install BALSAMIC | ||
- name: Install BALSAMIC | ||
id: install_balsamic | ||
shell: bash -l {0} | ||
run: | | ||
conda activate balsamic | ||
pip install --no-cache-dir -r requirements-dev.txt -r requirements.txt | ||
pip install -e . | ||
|
||
# Run PyTest | ||
- name: Run PyTest | ||
id: pytest | ||
shell: bash -l {0} | ||
run: | | ||
conda activate balsamic | ||
py.test --cov-report=xml --cov=BALSAMIC -rsxv tests/* | ||
|
||
# Run Codecov | ||
- name: Upload coverage to Codecov | ||
uses: codecov/codecov-action@v1 | ||
with: | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
file: ./coverage.xml | ||
flags: unittests | ||
fail_ci_if_error: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
pytest>=3.7.1 | ||
pytest-cov==2.8.1 | ||
coveralls==2.0.0 | ||
coveralls | ||
pylint |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Do you also need to include the path to report:
path_to_write_report: ./coverage/codecov_report.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line by line missing coverage could be because of this. I'll check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is there: https://codecov.io/gh/Clinical-Genomics/BALSAMIC/src/refactor%2Fremove_mutect2_gatk38/BALSAMIC/
Master is missing, and I guess that's why we don't get a cov report. I'll merge this to develop and go from there.