Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JuMP and Ipopt compat upgrade #85

Merged
merged 2 commits into from
Nov 12, 2022
Merged

JuMP and Ipopt compat upgrade #85

merged 2 commits into from
Nov 12, 2022

Conversation

fonsp
Copy link
Member

@fonsp fonsp commented Nov 4, 2022

Let's see if the tests pass

@fonsp fonsp marked this pull request as ready for review November 4, 2022 17:51
@fonsp fonsp marked this pull request as draft November 4, 2022 17:51
@fonsp
Copy link
Member Author

fonsp commented Nov 4, 2022

Looks like the Ipopt version is still bound by another dependency: https://github.com/ClimateMARGO/ClimateMARGO.jl/actions/runs/3395776825/jobs/5646082485#step:4:61

@fonsp
Copy link
Member Author

fonsp commented Nov 4, 2022

The latest test run passed with JuMP v1 and Ipopt v1, both at the latest versions! 🎉

Note that we have tests that pin the output of ClimateMARGO:

@testset "Pinned results" begin
This means that the JuMP and Ipopt upgrades did not change the output of ClimateMARGO, at least not for the functionality we test there.

@fonsp fonsp requested a review from hdrake November 4, 2022 18:12
@fonsp fonsp changed the title Ipopt compat upgrade JuMP and Ipopt compat upgrade Nov 4, 2022
@fonsp fonsp marked this pull request as ready for review November 4, 2022 18:12
@hdrake
Copy link
Collaborator

hdrake commented Nov 12, 2022

Wow, that's great news. Thanks for this update Fons!

@hdrake hdrake merged commit 12a0ce6 into main Nov 12, 2022
@hdrake hdrake deleted the fonsp-patch-2 branch November 12, 2022 14:53
Copy link
Collaborator

@hdrake hdrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants