Further updates to wdf correction #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brews
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
This looks like a clean addition, @dgergel.
I'd accept this as it is but there is one needed change. I wanted to be sure your changelog note isn't added to a section that has already been released. I have an in-line comment on this.
Aside from this one change/lconfirmation, I think you can merge this when you're ready.
Thanks!
…o further_updates_to_wdf_correction
brews
added a commit
to ClimateImpactLab/downscaleCMIP6
that referenced
this pull request
Dec 22, 2021
This tests fixes and tweaks to precipitation downscaling wet-day frequency correction. (e.g. ClimateImpactLab/dodola#159) NOTE, this switches from a pinned image release to a floating `dodola:dev` image. This should be repinned to a proper, versioned dodola release once we're happy.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update WDF correction further to avoid precip values "blowing up"