update DTR validation to include data type and different min validati… #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, we're going to have to accommodate these changes in https://raw.githubusercontent.com/ClimateImpactLab/downscaleCMIP6/master/workflows/templates/qualitycontrol-check-cmip6.yaml -- this PR will break this Workflow. |
|
thanks @brews - merging now. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates DTR validation to differentiate bw CMIP6 and bias corrected/downscaled allowed min values. This is because CMIP6 data, before applying the DTR small values "correction", may have zero values if tasmin > tasmax and those have been swapped.
Also cleaned up a bit of other DTR validation in this one.
addresses this GFDL DTR run bug: ClimateImpactLab/downscaleCMIP6#452