Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update biascorrection validation #146

Merged

Conversation

dgergel
Copy link
Member

@dgergel dgergel commented Dec 3, 2021

This PR updates validation of the number of timesteps in a bias corrected or downscaled output file to account for models that end in 2099 versus 2100.

Addresses the issue with some models ClimateImpactLab/downscaleCMIP6#383

@dgergel dgergel requested a review from brews December 3, 2021 17:19
@brews brews self-assigned this Dec 3, 2021
@brews brews added the bug Something isn't working label Dec 3, 2021
Copy link
Member

@brews brews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch and what looks like a clean fix. Thanks @dgergel!

I'll merge this an release a patch ASAP so we can run with this.

@brews brews merged commit 9b6589c into ClimateImpactLab:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants