Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update temp range max to 360K #142

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

dgergel
Copy link
Member

@dgergel dgergel commented Dec 1, 2021

Raising the validation limit for tasmax because a few models have max values that are slightly higher than this (they go up to 355K for MIROC6 ssp585 and 351K for KIOST-ESM). This is extremely high, but I think we want to keep as is for now.

@dgergel dgergel requested a review from brews December 1, 2021 00:28
@dgergel dgergel self-assigned this Dec 1, 2021
Copy link
Member

@brews brews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think you're good to merge this whenever you're ready @dgergel

@brews
Copy link
Member

brews commented Dec 1, 2021

For the record this is likely needed for progress on ClimateImpactLab/downscaleCMIP6#358 and ClimateImpactLab/downscaleCMIP6#347.

@brews brews merged commit 6ae7db6 into ClimateImpactLab:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants