Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dtr range check max to 70 C #138

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Update dtr range check max to 70 C #138

merged 2 commits into from
Nov 22, 2021

Conversation

brews
Copy link
Member

@brews brews commented Nov 22, 2021

This PR bumps the dtr validation to accept ranges to accept dtr values up to 70 degrees C. This is up from 40 degrees. It's based on ranges we found in a preliminary survey of CMIP6 GCMs.

@brews brews self-assigned this Nov 22, 2021
@brews brews requested a review from dgergel November 22, 2021 22:14
Copy link
Member

@dgergel dgergel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brews brews merged commit 5d560b8 into main Nov 22, 2021
@brews brews deleted the new_dtr_range branch November 22, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants