Merge pull request #1487 from lobachpavel/fix-enum-zero

fix enum parse logic when its last index is zero
ClickHouse · Feb 3, 2025 · 9ae8c68 · 9ae8c68
2 parents 418f672 + cf30194
commit 9ae8c68
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/column/enum.go b/lib/column/enum.go
@@ -179,7 +179,7 @@ func extractEnumNamedValues(chType Type) (typ string, values []string, indexes [
 	}
 
 	// Enum type must have at least one value
-	if valueIndex == 0 {
+	if len(indexes) == 0 {
 		return
 	}
 

diff --git a/lib/column/enum_test.go b/lib/column/enum_test.go
@@ -134,6 +134,15 @@ func TestExtractEnumNamedValues(t *testing.T) {
 				2: "",
 			},
 		},
+		{
+			name:         "Enum8 from negative to zero keys",
+			chType:       "Enum8('a'=-1, 'b'=0)",
+			expectedType: "Enum8",
+			expectedValues: map[int]string{
+				-1: "a",
+				0:  "b",
+			},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-Original file line number
+Diff line change
@@ Expand Up @@
     	}
     	// Enum type must have at least one value
-    	if valueIndex == 0 {
+    	if len(indexes) == 0 {
     		return
     	}
@@ Expand Down @@