Skip to content

Commit

Permalink
Support scan from uint8 to bool (#1051)
Browse files Browse the repository at this point in the history
* support scan from uint8 to bool

* update column template

* scan uint8 to bool test

---------

Co-authored-by: Kuba Kaflik <[email protected]>
  • Loading branch information
ValManP and jkaflik authored Aug 10, 2023
1 parent 0a19cff commit 2a6e542
Show file tree
Hide file tree
Showing 3 changed files with 71 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/column/codegen/column.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ func (col *{{ .ChType }}) ScanRow(dest any, row int) error {
case *sql.Null{{ .ChType }}:
return d.Scan(value)
{{- end }}
{{- if eq .ChType "Int8" }}
{{- if or (eq .ChType "Int8") (eq .ChType "UInt8") }}
case *bool:
switch value {
case 0:
Expand Down
7 changes: 7 additions & 0 deletions lib/column/column_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

63 changes: 63 additions & 0 deletions tests/uint8_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
// Licensed to ClickHouse, Inc. under one or more contributor
// license agreements. See the NOTICE file distributed with
// this work for additional information regarding copyright
// ownership. ClickHouse, Inc. licenses this file to you under
// the Apache License, Version 2.0 (the "License"); you may
// not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

package tests

import (
"context"
"github.com/ClickHouse/clickhouse-go/v2"
"github.com/stretchr/testify/require"
"testing"
)

func TestBoolUInt8(t *testing.T) {
ctx := context.Background()

conn, err := GetNativeConnection(clickhouse.Settings{
"max_execution_time": 60,
}, nil, &clickhouse.Compression{
Method: clickhouse.CompressionLZ4,
})
require.NoError(t, err)

const ddl = `
CREATE TABLE IF NOT EXISTS issue_1050 (
Col1 UInt8
, Col2 UInt8
) Engine MergeTree() ORDER BY tuple()
`
require.NoError(t, conn.Exec(ctx, ddl))
defer func() {
require.NoError(t, conn.Exec(ctx, "DROP TABLE IF EXISTS issue_1050"))
}()

batch, err := conn.PrepareBatch(ctx, "INSERT INTO issue_1050 (Col1, Col2)")
require.NoError(t, err)
require.NoError(t, batch.Append(true, false))
require.NoError(t, batch.Send())

row := conn.QueryRow(ctx, "SELECT Col1, Col2 from issue_1050")
require.NoError(t, err)

var (
col1 bool
col2 bool
)
require.NoError(t, row.Scan(&col1, &col2))
require.True(t, col1)
require.False(t, col2)
}

0 comments on commit 2a6e542

Please sign in to comment.