Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3(azure)queue: optimize requests to keeper #73991

Merged
merged 11 commits into from
Jan 10, 2025

Conversation

kssenii
Copy link
Member

@kssenii kssenii commented Dec 30, 2024

Depends on #73546

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

In Storage S3(Azure)Queue commit all files (in a single butch defined by commit settings) in a single keeper transaction.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory
and will run independently of the checks below:

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64
  • Exclude: All with release
  • Exclude: All with debug

  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-improvement Pull request with some product improvements label Dec 30, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Dec 30, 2024

This is an automated comment for commit 05fada8 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@kssenii kssenii force-pushed the s3queue-commit-files-in-one-transaction branch from af62a8e to fd26989 Compare January 8, 2025 16:41
@kssenii kssenii marked this pull request as ready for review January 9, 2025 12:23
@kssenii kssenii requested a review from antonio2368 January 10, 2025 10:09
@kssenii
Copy link
Member Author

kssenii commented Jan 10, 2025

Integration tests (asan, old analyzer) [2/6] — fail: 5, passed: 542

test_rename_column -- not related to changes

@kssenii kssenii enabled auto-merge January 10, 2025 14:30
@kssenii kssenii added this pull request to the merge queue Jan 10, 2025
Merged via the queue into master with commit 33e14f7 Jan 10, 2025
87 of 91 checks passed
@kssenii kssenii deleted the s3queue-commit-files-in-one-transaction branch January 10, 2025 15:00
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants