Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Get rid of the legacy mongodb integration" #73359

Merged
merged 11 commits into from
Dec 17, 2024

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Dec 16, 2024

#63279 introduced a new mongoDB driver. This was first released in v24.10. The old driver remained the default.

#63279 removed the old driver (appears in v24.12).

Many users only upgrade from LTS release to LTS release, but there has been no LTS release where old + new mongoDB drivers are available.

This PR reverts #63279 but makes the new driver the default. This will increase the margin of safety for users with LTS requirements. Sorry for the hassle, I should have noticed earlier when I reviewed #63279.

The final removal of the old driver can be done after v25.2 LTS.

@allmazz

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

A new MongoDB driver is now the default. Users who like to continue using the legacy driver can set server setting use_legacy_mongodb_integration to true.

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-improvement Pull request with some product improvements label Dec 16, 2024
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Dec 16, 2024

This is an automated comment for commit 1fd0966 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@rschu1ze rschu1ze enabled auto-merge December 17, 2024 15:52
@rschu1ze rschu1ze added this pull request to the merge queue Dec 17, 2024
Merged via the queue into ClickHouse:master with commit 5690b56 Dec 17, 2024
212 of 217 checks passed
@rschu1ze rschu1ze deleted the revert-legacy-mongo-removal branch December 17, 2024 17:03
robot-clickhouse-ci-2 added a commit that referenced this pull request Dec 17, 2024
Cherry pick #73359 to 24.12: Revert "Get rid of the legacy mongodb integration"
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 17, 2024
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 17, 2024
rschu1ze added a commit to rschu1ze/ClickHouse that referenced this pull request Dec 17, 2024
rschu1ze added a commit to rschu1ze/ClickHouse that referenced this pull request Dec 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 17, 2024
Update CHANGELOG.md to account for #73359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo v24.12-must-backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants