-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Get rid of the legacy mongodb integration" #73359
Merged
rschu1ze
merged 11 commits into
ClickHouse:master
from
rschu1ze:revert-legacy-mongo-removal
Dec 17, 2024
Merged
Revert "Get rid of the legacy mongodb integration" #73359
rschu1ze
merged 11 commits into
ClickHouse:master
from
rschu1ze:revert-legacy-mongo-removal
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdimir
approved these changes
Dec 16, 2024
Contributor
This is an automated comment for commit 1fd0966 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
allmazz
approved these changes
Dec 16, 2024
Merged
via the queue into
ClickHouse:master
with commit Dec 17, 2024
5690b56
212 of 217 checks passed
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Dec 17, 2024
Cherry pick #73359 to 24.12: Revert "Get rid of the legacy mongodb integration"
robot-clickhouse
added a commit
that referenced
this pull request
Dec 17, 2024
rschu1ze
added a commit
to rschu1ze/ClickHouse
that referenced
this pull request
Dec 17, 2024
rschu1ze
added a commit
to rschu1ze/ClickHouse
that referenced
this pull request
Dec 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Update CHANGELOG.md to account for #73359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-improvement
Pull request with some product improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
v24.12-must-backport
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#63279 introduced a new mongoDB driver. This was first released in v24.10. The old driver remained the default.
#63279 removed the old driver (appears in v24.12).
Many users only upgrade from LTS release to LTS release, but there has been no LTS release where old + new mongoDB drivers are available.
This PR reverts #63279 but makes the new driver the default. This will increase the margin of safety for users with LTS requirements. Sorry for the hassle, I should have noticed earlier when I reviewed #63279.
The final removal of the old driver can be done after v25.2 LTS.
@allmazz
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
A new MongoDB driver is now the default. Users who like to continue using the legacy driver can set server setting
use_legacy_mongodb_integration
to true.