Add S3DiskNoKeyErrors metric

[mstetsyuk]

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add S3DiskNoKeyErrors metric

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

• Allow: All Required Checks
• Allow: Stateless tests
• Allow: Stateful tests
• Allow: Integration Tests
• Allow: Performance tests
• Allow: All Builds
• Allow: batch 1, 2 for multi-batch jobs
• Allow: batch 3, 4, 5, 6 for multi-batch jobs

---

• Exclude: Style check
• Exclude: Fast test
• Exclude: All with ASAN
• Exclude: All with TSAN, MSAN, UBSAN, Coverage
• Exclude: All with aarch64, release, debug

---

• Do not test
• Woolen Wolfdog
• Upload binaries for special builds
• Disable merge-commit
• Disable CI cache

[robot-ch-test-poll2]

This is an automated comment for commit 34cba1b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

[mstetsyuk]

Failing CI:

• Integration test test_host_resolver_fail_count has been removed: Remove bad test host_resolver_fail_count #66731
• Stateless tests did not finish because the clickhouse-test process was terminated, here's the fix: Update ci_config.py #66783
• Stateless test async_insert_skip_settings is being looked into

[CheSema]

Are you sure that you are counting here NoSuchKey? it is not so obvious.

[CheSema]

Why don't we put such counters inside enrichErrorMessage?
May be it would require rename the function. But in that case we would have one point when we catch the error code.

[CheSema]

How could it be tested?

[mstetsyuk]

How could it be tested?

All I can think of is an integration test where some object is removed from S3. But it looks like integration tests don't support removing objects from S3, so maybe you have something simpler in mind, @CheSema?

[CheSema]

How could it be tested?

All I can think of is an integration test where some object is removed from S3. But it looks like integration tests don't support removing objects from S3, so maybe you have something simpler in mind, @CheSema?

It is possible to remove something or even all s3 data in integration tests. For example tests/integration/test_checking_s3_blobs_paranoid/test.py::test_no_key_found_disk does that.

You could check your counter inside this test as well.

Also please find some other tests which triggers some other S3 errors and check that your counter is 0.

[CheSema]

may be sum(value) otherwise you could have several integers values as a result.

[mstetsyuk]

There can only be one row in the result because there's only one row in system.metrics where metric = 'S3DiskNoKeyErrors' if I understood you correctly.

[CheSema]

You are right.