-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable suspend on Ctrl+Z in the interactive mode #66511
Conversation
This is an automated comment for commit 390ed8d with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me as long as it affects only the shell
mode, which as far as I could test, it seems like that's the case.
@@ -362,6 +362,9 @@ ReplxxLineReader::ReplxxLineReader( | |||
rx.bind_key(Replxx::KEY::control('N'), [this](char32_t code) { return rx.invoke(Replxx::ACTION::HISTORY_NEXT, code); }); | |||
rx.bind_key(Replxx::KEY::control('P'), [this](char32_t code) { return rx.invoke(Replxx::ACTION::HISTORY_PREVIOUS, code); }); | |||
|
|||
/// We don't want the default, "suspend" behavior, it confuses people. | |||
rx.bind_key_internal(replxx::Replxx::KEY::control('Z'), "insert_character"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexey-milovidov I use this all the time
I like keeping this configurable While there is hardly any point putting interactive shell jobs in the background these days it feels hacky twisting the shell's built-in shortcuts |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Disable suspending on Ctrl+Z in interactive mode. This is a common trap and is not expected behavior for almost all users. I imagine only a few extreme power users could appreciate suspending terminal applications to the background, but I don't know any.
CI Settings (Only check the boxes if you know what you are doing):