-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL compatibility: toDayOfWeek()
now supports string arguments
#55589
Merged
rschu1ze
merged 6 commits into
ClickHouse:master
from
rschu1ze:string-args-in-week-functions
Oct 16, 2023
Merged
MySQL compatibility: toDayOfWeek()
now supports string arguments
#55589
rschu1ze
merged 6 commits into
ClickHouse:master
from
rschu1ze:string-args-in-week-functions
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
This is an automated comment for commit dcedc5f with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
slvrtrn
reviewed
Oct 13, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
slvrtrn
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely based on #55572 (kudos to @slvrtrn) but solves the task a) a bit more elegantly + b) also for
toWeek()
andtoYearWeek()
Resolves #54794
(refactorings are contained in a separate commit, it is easier to review https://github.com/ClickHouse/ClickHouse/pull/55589/commits individually)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Functions
toDayOfWeek()
(MySQL alias:DAYOFWEEK()
),toYearWeek()
(YEARWEEK()
) andtoWeek()
(WEEK()
) now supportsString
arguments. This makes its behavior consistent with MySQL's behavior.