-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filtering parts with indexHint for non analyzer (resubmit) #54825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Azat Khuzhin <[email protected]> (cherry picked from commit ffa82e9)
Contributor
This is an automated comment for commit 9c3fb64 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
f3d7f6b
to
68a49a7
Compare
This should fix filtering by virtual columns with non-uint8 types, i.e. queries like: SELECT * FROM data WHERE 1.0 Fixes: 02346_full_text_search Fixes: 00990_hasToken_and_tokenbf v2: move check out from is_const to filterBlockWithQuery(), since in is_const there is no way to validate sets. Signed-off-by: Azat Khuzhin <[email protected]>
68a49a7
to
9c3fb64
Compare
|
Avogar
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix filtering parts with indexHint for non analyzer
Fixes: #54185 (cc @KochetovNicolai )
Resubmits: #54449 (cc @Avogar ) - it had been reverted in #54806, due to conflicts with newly added tests in #54563
Fixes: #54563 (Cc @rschu1ze) - add proper type check into virtual column utils