-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToString() performance improvement and code cleanup #54443
ToString() performance improvement and code cleanup #54443
Conversation
This is an automated comment for commit 12ce573 with description of existing statuses. It's updated for the latest CI running
|
src/Functions/FunctionsConversion.h
Outdated
@@ -990,20 +990,11 @@ struct ConvertImpl<FromDataType, DataTypeString, Name, ConvertDefaultBehaviorTag | |||
{ | |||
ColumnUInt8::MutablePtr null_map = copyNullMap(arguments[0].column); | |||
|
|||
const auto & col_with_type_and_name = columnGetNested(arguments[0]); | |||
const auto & col_with_type_and_name = columnGetNested(arguments[0]); | |||
const auto & type = static_cast<const FromDataType &>(*col_with_type_and_name.type); | |||
|
|||
const DateLUTImpl * time_zone = nullptr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an extra whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm talking about time_zone
variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removed it, thanks
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Since we use separate instructions for executing
toString()
with datetime argument, it is possible to improve performance a bit for non-datetime arguments and have some parts of the code cleaner. Follows up #53680.Documentation entry for user-facing changes