-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix throttling of BACKUPs from/to S3 (in case native copy was not used) and in some other places as well #53336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
This is an automated comment for commit c706101 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
6129e93
to
8d9dc39
Compare
|
@vitlibar can you take a look? |
Rebased (#53533) |
8d9dc39
to
61c00f8
Compare
@vitlibar kind ping |
vitlibar
reviewed
Sep 6, 2023
vitlibar
reviewed
Sep 6, 2023
61c00f8
to
52ce4e1
Compare
vitlibar
reviewed
Sep 14, 2023
52ce4e1
to
687bc5d
Compare
vitlibar
reviewed
Sep 20, 2023
vitlibar
approved these changes
Sep 20, 2023
vitlibar
reviewed
Sep 20, 2023
687bc5d
to
519fe73
Compare
In some cases native copy is not possible, and such requests should be throttled. v0: copyS3FileNativeWithFallback v2: revert v0 and pass write_settings v3: pass read_settings to copyFile() Signed-off-by: Azat Khuzhin <[email protected]>
519fe73
to
c706101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix throttling of BACKUPs from/to S3 (in case native copy was not used) and in some other places as well
In some cases native copy is not possible, and such requests should be throttled.
Fixes: #51448 (note, actually this implementation bit got lost during multiple review stages)
Cc: @vitlibar