Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix throttling of BACKUPs from/to S3 (in case native copy was not used) and in some other places as well #53336

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

azat
Copy link
Member

@azat azat commented Aug 11, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix throttling of BACKUPs from/to S3 (in case native copy was not used) and in some other places as well

In some cases native copy is not possible, and such requests should be throttled.

Fixes: #51448 (note, actually this implementation bit got lost during multiple review stages)

Cc: @vitlibar

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Aug 11, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Aug 11, 2023

This is an automated comment for commit c706101 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@azat azat force-pushed the backups/s3-throttling branch from 6129e93 to 8d9dc39 Compare August 11, 2023 14:32
@azat
Copy link
Member Author

azat commented Aug 12, 2023

Performance Comparison [3/4] — 1 errors

@azat
Copy link
Member Author

azat commented Aug 15, 2023

@vitlibar can you take a look?

@azat
Copy link
Member Author

azat commented Aug 30, 2023

Conflicting files
src/Disks/ObjectStorages/S3/S3ObjectStorage.cpp
src/IO/S3/copyS3File.cpp
src/IO/S3/copyS3File.h

Rebased (#53533)

@azat azat force-pushed the backups/s3-throttling branch from 8d9dc39 to 61c00f8 Compare August 30, 2023 08:53
@vitlibar vitlibar self-assigned this Aug 30, 2023
@azat
Copy link
Member Author

azat commented Sep 4, 2023

@vitlibar kind ping

@azat azat force-pushed the backups/s3-throttling branch from 61c00f8 to 52ce4e1 Compare September 6, 2023 17:50
@azat azat requested a review from vitlibar September 11, 2023 10:03
@azat azat requested a review from vitlibar September 18, 2023 13:22
@azat azat force-pushed the backups/s3-throttling branch from 52ce4e1 to 687bc5d Compare September 20, 2023 12:53
@azat azat force-pushed the backups/s3-throttling branch from 687bc5d to 519fe73 Compare September 20, 2023 14:27
In some cases native copy is not possible, and such requests should be
throttled.

v0: copyS3FileNativeWithFallback
v2: revert v0 and pass write_settings
v3: pass read_settings to copyFile()
Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat force-pushed the backups/s3-throttling branch from 519fe73 to c706101 Compare September 20, 2023 16:29
@azat azat changed the title Fix throttling of BACKUPs from/to S3 (in case native copy was not used) Fix throttling of BACKUPs from/to S3 (in case native copy was not used) and in some other places as well Sep 20, 2023
@vitlibar vitlibar merged commit bf4662a into ClickHouse:master Sep 21, 2023
@azat azat deleted the backups/s3-throttling branch September 21, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants