Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system stop pulling replication log #52881

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Conversation

tavplubix
Copy link
Member

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added SYSTEM STOP/START PULLING REPLICATION LOG queries (for testing ReplicatedMergeTree)

@robot-ch-test-poll robot-ch-test-poll added the pr-feature Pull request with new product feature label Aug 1, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Aug 1, 2023

This is an automated comment for commit 8daa6f4 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Mergeable CheckChecks if all other necessary checks are successful🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success

@tavplubix
Copy link
Member Author

Initially, I tried to write a test for a race condition between StorageReplicatedMergeTree::updateQuorum and StorageReplicatedMergeTree::cleanLastPartNode: https://gist.github.com/tavplubix/b2c5d98c0995ff9e986ca6f95827d190

However, this race condition is quite rare and not harmful, nobody cares about it, and a fix would require a backward incompatible change... So it's easier to keep it as is.

@tavplubix tavplubix force-pushed the fix_race_in_quorum_inserts branch from 5b89a01 to 571c11a Compare August 1, 2023 19:58
@tavplubix tavplubix force-pushed the fix_race_in_quorum_inserts branch from 571c11a to 634ca14 Compare August 1, 2023 20:24
@@ -197,6 +197,7 @@ namespace ActionLocks
extern const StorageActionBlockType ReplicationQueue;
extern const StorageActionBlockType PartsTTLMerge;
extern const StorageActionBlockType PartsMove;
extern StorageActionBlockType PullReplicationLog;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extern StorageActionBlockType PullReplicationLog;
extern const StorageActionBlockType PullReplicationLog;

@evillique evillique self-assigned this Aug 2, 2023
@tavplubix tavplubix requested a review from evillique August 2, 2023 09:42
@tavplubix
Copy link
Member Author

I hate tests for RBAC

@tavplubix
Copy link
Member Author

Stress test (asan) - #52978
Upgrade check is broken in master

@tavplubix tavplubix merged commit 7684e68 into master Aug 3, 2023
@tavplubix tavplubix deleted the fix_race_in_quorum_inserts branch August 3, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants