-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system stop pulling replication log #52881
Conversation
This is an automated comment for commit 8daa6f4 with description of existing statuses. It's updated for the latest CI running
|
Initially, I tried to write a test for a race condition between However, this race condition is quite rare and not harmful, nobody cares about it, and a fix would require a backward incompatible change... So it's easier to keep it as is. |
5b89a01
to
571c11a
Compare
571c11a
to
634ca14
Compare
@@ -197,6 +197,7 @@ namespace ActionLocks | |||
extern const StorageActionBlockType ReplicationQueue; | |||
extern const StorageActionBlockType PartsTTLMerge; | |||
extern const StorageActionBlockType PartsMove; | |||
extern StorageActionBlockType PullReplicationLog; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extern StorageActionBlockType PullReplicationLog; | |
extern const StorageActionBlockType PullReplicationLog; |
I hate tests for RBAC |
Stress test (asan) - #52978 |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added
SYSTEM STOP/START PULLING REPLICATION LOG
queries (for testingReplicatedMergeTree
)