-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run cargo update to fix build with nightly #51721
Conversation
This is an automated comment for commit cdc0fd1 with description of existing statuses. It's updated for the latest CI running
|
Test failures:
|
|
@Algunenano, can we also pin Rust to whatever snapshot, git hash, etc... that works today, instead of "nightly"? |
In theory it should be possible with something like:
This is how the documentation says should work, but it doesn't. It didn't complain about me not having it installed and if I set it to a wrong date in the future it doesn't complain either. Maybe it has something to do with how corrosion picks up things. Maybe we could document it without actually enforcing it. |
Backport #51721 to 23.6: Run cargo update to fix build with nightly
Backport #51721 to 23.5: Run cargo update to fix build with nightly
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Documentation entry for user-facing changes
Closes #51699
Since #50541 rust nightly is necessary, but building with a recent nightly is impossible because of old dependencies. Just update them.