Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grace_hash join by reserving hash table's size #50875

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

lgbo-ustc
Copy link
Contributor

@lgbo-ustc lgbo-ustc commented Jun 12, 2023

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Improve grace_hash join by reserving hash table's size (resubmit)

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@lgbo-ustc
Copy link
Contributor Author

@vdimir Would you make this ci run ? We notice that all the failures about adding joined blocks in a hash_join which is released is after the pr #49816. We add some debug codes in this new pr and try to make it reproduced.

@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve__debug branch 2 times, most recently from d42d216 to 6a7b135 Compare June 13, 2023 01:31
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-performance Pull request with some performance improvements label Jun 13, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Jun 13, 2023

This is an automated comment for commit d3a6392 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@nickitat nickitat added the can be tested Allows running workflows for external contributors label Jun 13, 2023
@nickitat nickitat self-assigned this Jun 13, 2023
@nickitat
Copy link
Member

@lgbo-ustc Vladimir is on vacation, tag me if you need any help

@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve__debug branch 3 times, most recently from 79a9b61 to e7f4130 Compare June 15, 2023 01:42
@lgbo-ustc
Copy link
Contributor Author

@nickitat will you trigger this ci ?

@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve__debug branch from 4fe3997 to 662cfda Compare June 16, 2023 05:18
@lgbo-ustc
Copy link
Contributor Author

@nickitat will you trigger this ci ?

@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve__debug branch 2 times, most recently from ce65f7a to 8d81323 Compare June 28, 2023 08:37
@lgbo-ustc lgbo-ustc changed the title [WIP-Debug]Improve grace_hash join by reserving hash table's size Improve grace_hash join by reserving hash table's size Jun 28, 2023
@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve__debug branch from 8d81323 to d0d4e14 Compare June 28, 2023 08:45
@ClickHouse ClickHouse deleted a comment from clickhouse-ci bot Jun 28, 2023
@ClickHouse ClickHouse deleted a comment from clickhouse-ci bot Jun 28, 2023
@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve__debug branch 2 times, most recently from 0f16341 to 0f031aa Compare July 3, 2023 01:28
@lgbo-ustc
Copy link
Contributor Author

lgbo-ustc commented Jul 3, 2023

@nickitat @vdimir would you review this again?

Copy link
Member

@nickitat nickitat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve__debug branch from 0f031aa to ab2b7cb Compare July 7, 2023 07:46
@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve__debug branch from ab2b7cb to d3a6392 Compare July 10, 2023 00:08
@lgbo-ustc
Copy link
Contributor Author

@nickitat could this be merged?

@nickitat nickitat merged commit 344bc05 into ClickHouse:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants