-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT compilation not equals NaN fix #50056
Merged
alexey-milovidov
merged 2 commits into
ClickHouse:master
from
kitaisreal:jit-compilation-not-equals-nan-fix
May 22, 2023
Merged
JIT compilation not equals NaN fix #50056
alexey-milovidov
merged 2 commits into
ClickHouse:master
from
kitaisreal:jit-compilation-not-equals-nan-fix
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
This is an automated comment for commit 01c01bf with description of existing statuses. It's updated for the latest CI running
|
To check what LLVM emits: bool equals(double f1, double f2) {
return f1 == f2;
}
bool notEquals(double f1, double f2) {
return f1 != f2;
}
bool less(double f1, double f2) {
return f1 < f2;
}
bool lessOrEquals(double f1, double f2) {
return f1 <= f2;
}
bool greater(double f1, double f2) {
return f1 > f2;
}
bool greaterOrEquals(double f1, double f2) {
return f1 >= f2;
}
int main(int agrc, char ** argv) {
return 0;
} Emit IR:
Result:
|
alexey-milovidov
approved these changes
May 21, 2023
1756b02
to
97d2040
Compare
97d2040
to
01c01bf
Compare
robot-clickhouse
added a commit
that referenced
this pull request
May 22, 2023
robot-clickhouse
added a commit
that referenced
this pull request
May 22, 2023
robot-clickhouse
added a commit
that referenced
this pull request
May 22, 2023
robot-clickhouse
added a commit
that referenced
this pull request
May 22, 2023
nikitamikhaylov
added a commit
that referenced
this pull request
May 26, 2023
Backport #50056 to 22.8: JIT compilation not equals NaN fix
nikitamikhaylov
added a commit
that referenced
this pull request
May 26, 2023
Backport #50056 to 23.2: JIT compilation not equals NaN fix
nikitamikhaylov
added a commit
that referenced
this pull request
May 26, 2023
Backport #50056 to 23.3: JIT compilation not equals NaN fix
nikitamikhaylov
added a commit
that referenced
this pull request
May 26, 2023
Backport #50056 to 23.4: JIT compilation not equals NaN fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
notEquals
function JIT compilation when one of the arguments is NaN. Closes #50039.